1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
|
/*
* \file QualityTester.cc
*
* Harvesting module that applies Quality Tests to MonitorElements.
* Which tests are run an be configured using an XML-based configuration.
* \author Marcel Schneider
* based on M. Zanetti's older module.
*
*/
#include "FWCore/Framework/interface/EventSetup.h"
#include "FWCore/MessageLogger/interface/MessageLogger.h"
#include "FWCore/ServiceRegistry/interface/Service.h"
#include "FWCore/ParameterSet/interface/FileInPath.h"
#include "FWCore/Framework/interface/Event.h"
#include "FWCore/Framework/interface/MakerMacros.h"
#include "FWCore/ParameterSet/interface/ParameterSet.h"
#include "FWCore/Framework/interface/LuminosityBlock.h"
#include "DQMServices/Core/interface/DQMEDHarvester.h"
#include "DQMServices/Core/interface/QTest.h"
#include <cmath>
#include <memory>
#include <string>
#include <cstdio>
#include <sstream>
#include <iostream>
#include <boost/property_tree/xml_parser.hpp>
#include <boost/property_tree/ptree.hpp>
#include <fnmatch.h>
class QualityTester : public DQMEDHarvester {
public:
/// Constructor
QualityTester(const edm::ParameterSet& ps);
/// Destructor
~QualityTester() override;
protected:
/// perform the actual quality tests
void dqmAnalyze(DQMStore::IBooker&, DQMStore::IGetter&, const edm::Event& e, const edm::EventSetup& c) override;
void dqmEndLuminosityBlock(DQMStore::IBooker&,
DQMStore::IGetter&,
edm::LuminosityBlock const& lumiSeg,
edm::EventSetup const& c) override;
void dqmEndRun(DQMStore::IBooker&, DQMStore::IGetter&, const edm::Run& r, const edm::EventSetup& c) override;
void dqmEndJob(DQMStore::IBooker&, DQMStore::IGetter&) override;
private:
void performTests(DQMStore::IGetter& igetter);
int nEvents;
int prescaleFactor;
bool getQualityTestsFromFile;
std::string Label;
bool testInEventloop;
bool qtestOnEndRun;
bool qtestOnEndJob;
bool qtestOnEndLumi;
std::string reportThreshold;
bool verboseQT;
// this vector holds and owns all the QTest objects. mostly for memory management.
std::vector<std::unique_ptr<QCriterion>> qtestobjects;
// we use this structure to check which tests to run on which MEs. The first
// part is the pattern with wildcards matching MEs that the test should be
// applied to, the second points to an object in qtestobjects. We cannot own
// the objects here since more than one pattern can use the same test.
std::vector<std::pair<std::string, QCriterion*>> qtestpatterns;
void configureTests(std::string const& file);
std::unique_ptr<QCriterion> makeQCriterion(boost::property_tree::ptree const& config);
};
QualityTester::QualityTester(const edm::ParameterSet& ps) : DQMEDHarvester(ps) {
prescaleFactor = ps.getUntrackedParameter<int>("prescaleFactor", 1);
getQualityTestsFromFile = ps.getUntrackedParameter<bool>("getQualityTestsFromFile", true);
Label = ps.getUntrackedParameter<std::string>("label", "");
reportThreshold = ps.getUntrackedParameter<std::string>("reportThreshold", "");
testInEventloop = ps.getUntrackedParameter<bool>("testInEventloop", false);
qtestOnEndRun = ps.getUntrackedParameter<bool>("qtestOnEndRun", true);
qtestOnEndJob = ps.getUntrackedParameter<bool>("qtestOnEndJob", false);
qtestOnEndLumi = ps.getUntrackedParameter<bool>("qtestOnEndLumi", false);
verboseQT = ps.getUntrackedParameter<bool>("verboseQT", true);
if (getQualityTestsFromFile) {
edm::FileInPath qtlist = ps.getUntrackedParameter<edm::FileInPath>("qtList");
configureTests(qtlist.fullPath());
} else {
assert(!"Reading from DB no longer supported.");
}
nEvents = 0;
}
QualityTester::~QualityTester() {}
void QualityTester::dqmAnalyze(DQMStore::IBooker&,
DQMStore::IGetter& igetter,
const edm::Event& e,
const edm::EventSetup& c) {
if (testInEventloop) {
nEvents++;
if (prescaleFactor > 0 && nEvents % prescaleFactor == 0) {
performTests(igetter);
}
}
}
void QualityTester::dqmEndLuminosityBlock(DQMStore::IBooker&,
DQMStore::IGetter& igetter,
edm::LuminosityBlock const& lumiSeg,
edm::EventSetup const& context) {
if (!testInEventloop && qtestOnEndLumi) {
if (prescaleFactor > 0 && lumiSeg.id().luminosityBlock() % prescaleFactor == 0) {
performTests(igetter);
}
}
}
void QualityTester::dqmEndRun(DQMStore::IBooker&,
DQMStore::IGetter& igetter,
edm::Run const& run,
edm::EventSetup const& context) {
if (qtestOnEndRun)
performTests(igetter);
}
void QualityTester::dqmEndJob(DQMStore::IBooker&, DQMStore::IGetter& igetter) {
if (qtestOnEndJob)
performTests(igetter);
}
void QualityTester::performTests(DQMStore::IGetter& igetter) {
edm::LogVerbatim("QualityTester") << "Running the Quality Test";
auto mes = igetter.getAllContents("");
for (auto me : mes) {
std::string name = me->getFullname();
for (auto& kv : this->qtestpatterns) {
std::string& pattern = kv.first;
QCriterion* qtest = kv.second;
int match = fnmatch(pattern.c_str(), name.c_str(), 0);
if (match == FNM_NOMATCH)
continue;
if (match != 0)
throw cms::Exception("QualityTester")
<< "Something went wrong with fnmatch: pattern = '" << pattern << "' and string = '" << name << "'";
// name matched, apply test.
// Using the classic ME API for now.
QReport* qr;
DQMNet::QValue* qv;
me->getQReport(/* create */ true, qtest->getName(), qr, qv);
assert(qtest); // null might be valid, maybe replace with if
assert(qr);
assert(qv);
qtest->runTest(me, *qr, *qv);
// this propagates the result into the DQMNet object flags
me->syncCoreObject();
}
}
if (!reportThreshold.empty()) {
// map {red, orange, black} -> [QReport message, ...]
std::map<std::string, std::vector<std::string>> theAlarms;
// populate from MEs hasError, hasWarning, hasOther
for (auto me : mes) {
// TODO: This logic is rather broken and suppresses errors when there
// are warnings (or suppresses both when there are others. But this is
// how it always was, and we keep it for now for compatibility.
std::vector<QReport*> report;
std::string colour;
if (me->hasError()) {
colour = "red";
report = me->getQErrors();
}
if (me->hasWarning()) {
colour = "orange";
report = me->getQWarnings();
}
if (me->hasOtherReport()) {
colour = "black";
report = me->getQOthers();
}
for (auto r : report) {
theAlarms[colour].push_back(r->getMessage());
}
}
// writes to stdout, because it alyways wrote to stdout.
for (auto& theAlarm : theAlarms) {
const std::string& alarmType = theAlarm.first;
const std::vector<std::string>& msgs = theAlarm.second;
if ((reportThreshold == "black") ||
(reportThreshold == "orange" && (alarmType == "orange" || alarmType == "red")) ||
(reportThreshold == "red" && alarmType == "red")) {
std::cout << std::endl;
std::cout << "Error Type: " << alarmType << std::endl;
for (auto const& msg : msgs)
std::cout << msg << std::endl;
}
}
std::cout << std::endl;
}
}
std::unique_ptr<QCriterion> QualityTester::makeQCriterion(boost::property_tree::ptree const& config) {
// For whatever reasons the compiler needs the "template" keyword on ptree::get.
// To save some noise in the code we have the preprocessor add it everywhere.
#define get template get
// TODO: make the parameter names more consistent.
// TODO: add defaults where it makes sense.
std::map<std::string,
std::function<std::unique_ptr<QCriterion>(boost::property_tree::ptree const&, std::string& name)>>
qtestmakers = {{CheckVariance::getAlgoName(),
[](auto const& config, std::string& name) {
auto test = std::make_unique<CheckVariance>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
return test;
}},
{CompareLastFilledBin::getAlgoName(),
[](auto const& config, std::string& name) {
auto test = std::make_unique<CompareLastFilledBin>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
test->setAverage(config.get<float>("AvVal"));
test->setMin(config.get<float>("MinVal"));
test->setMax(config.get<float>("MaxVal"));
return test;
}},
{CompareToMedian::getAlgoName(),
[](auto const& config, std::string& name) {
auto test = std::make_unique<CompareToMedian>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
test->setMin(config.get<float>("MinRel"));
test->setMax(config.get<float>("MaxRel"));
test->setMinMedian(config.get<float>("MinAbs"));
test->setMaxMedian(config.get<float>("MaxAbs"));
test->setEmptyBins(config.get<int>("UseEmptyBins"));
test->setStatCut(config.get<float>("StatCut", 0));
return test;
}},
{ContentSigma::getAlgoName(),
[](auto const& config, std::string& name) {
auto test = std::make_unique<ContentSigma>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
test->setNumXblocks(config.get<int>("Xblocks"));
test->setNumYblocks(config.get<int>("Yblocks"));
test->setNumNeighborsX(config.get<int>("neighboursX"));
test->setNumNeighborsY(config.get<int>("neighboursY"));
test->setToleranceNoisy(config.get<double>("toleranceNoisy"));
test->setToleranceDead(config.get<double>("toleranceDead"));
test->setNoisy(config.get<double>("noisy"));
test->setDead(config.get<double>("dead"));
test->setXMin(config.get<int>("xMin"));
test->setXMax(config.get<int>("xMax"));
test->setYMin(config.get<int>("yMin"));
test->setYMax(config.get<int>("yMax"));
return test;
}},
{ContentsWithinExpected::getAlgoName(),
[](auto const& config, std::string& name) {
auto test = std::make_unique<ContentsWithinExpected>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
test->setUseEmptyBins(config.get<bool>("useEmptyBins"));
test->setMinimumEntries(config.get<int>("minEntries"));
test->setMeanTolerance(config.get<float>("toleranceMean"));
if (config.get<double>("minMean", 0) || config.get<double>("maxMean", 0))
test->setMeanRange(config.get<double>("minMean"), config.get<double>("maxMean"));
if (config.get<double>("minRMS", 0) || config.get<double>("maxRMS", 0))
test->setRMSRange(config.get<double>("minRMS"), config.get<double>("maxRMS"));
return test;
}},
{ContentsXRange::getAlgoName(),
[](auto const& config, std::string& name) {
auto test = std::make_unique<ContentsXRange>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
test->setAllowedXRange(config.get<double>("xmin"), config.get<double>("xmax"));
return test;
}},
{ContentsYRange::getAlgoName(),
[](auto const& config, std::string& name) {
auto test = std::make_unique<ContentsYRange>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
test->setAllowedYRange(config.get<double>("ymin"), config.get<double>("ymax"));
test->setUseEmptyBins(config.get<bool>("useEmptyBins"));
return test;
}},
{DeadChannel::getAlgoName(),
[](auto const& config, std::string& name) {
auto test = std::make_unique<DeadChannel>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
test->setThreshold(config.get<float>("threshold"));
return test;
}},
{MeanWithinExpected::getAlgoName(),
[](auto const& config, std::string& name) {
auto test = std::make_unique<MeanWithinExpected>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
test->setMinimumEntries(config.get<int>("minEntries", 0));
test->setExpectedMean(config.get<double>("mean"));
if (config.get<double>("useSigma", 0))
test->useSigma(config.get<double>("useSigma"));
if (config.get<int>("useRMS", 0))
test->useRMS();
if (config.get<int>("useRange", 0))
test->useRange(config.get<float>("xmin"), config.get<float>("xmax"));
return test;
}},
{NoisyChannel::getAlgoName(), [](auto const& config, std::string& name) {
auto test = std::make_unique<NoisyChannel>(name);
test->setWarningProb(config.get<float>("warning", QCriterion::WARNING_PROB_THRESHOLD));
test->setErrorProb(config.get<float>("error", QCriterion::ERROR_PROB_THRESHOLD));
test->setTolerance(config.get<double>("tolerance"));
test->setNumNeighbors(config.get<double>("neighbours"));
return test;
}}};
#undef get
auto maker = qtestmakers.find(config.get<std::string>("TYPE"));
// Check if the type is known, error out otherwise.
if (maker == qtestmakers.end())
return nullptr;
// The QTest XML format has structure
// <QTEST><TYPE>QTestClass</TYPE><PARAM name="thing">value</PARAM>...</QTEST>
// but that is a pain to read with property_tree. So we reorder the structure
// and add a child "thing" with data "value" for each param to a new tree.
// Then the qtestmakers can just config.get<type>("thing").
boost::property_tree::ptree reordered;
for (auto kv : config) {
// TODO: case sensitive?
if (kv.first == "PARAM") {
reordered.put(kv.second.get<std::string>("<xmlattr>.name"), kv.second.data());
}
}
auto name = config.get<std::string>("<xmlattr>.name");
return maker->second(reordered, name);
}
void QualityTester::configureTests(std::string const& file) {
// We read QTests from the config file into this structure, before
// transforming into the final [(pattern, *qtest), ...] structure.
struct TestItem {
std::unique_ptr<QCriterion> qtest;
std::vector<std::string> pathpatterns;
};
std::map<std::string, TestItem> qtestmap;
// read XML using property tree. Should throw on error.
boost::property_tree::ptree xml;
boost::property_tree::read_xml(file, xml);
auto it = xml.find("TESTSCONFIGURATION");
if (it == xml.not_found()) {
throw cms::Exception("QualityTester") << "QTest XML needs to have a TESTSCONFIGURATION node.";
}
auto& testconfig = it->second;
for (auto& kv : testconfig) {
// QTEST describes a QTest object (actually QCriterion) with its parameters
if (kv.first == "QTEST") {
auto& qtestconfig = kv.second;
auto name = qtestconfig.get<std::string>("<xmlattr>.name");
auto value = makeQCriterion(qtestconfig);
// LINK and QTEST can be in any order, so this element may or may not exist
qtestmap[name].qtest = std::move(value);
} // else
// LINK associates one ore more QTest referenced by name to a ME path pattern.
if (kv.first == "LINK") {
auto& linkconfig = kv.second;
auto pathpattern = linkconfig.get<std::string>("<xmlattr>.name");
for (auto& subkv : linkconfig) {
if (subkv.first == "TestName") {
std::string testname = subkv.second.data();
bool enabled = subkv.second.get<bool>("<xmlattr>.activate");
if (enabled) {
// LINK and QTEST can be in any order, so this element may or may not exist
qtestmap[testname].pathpatterns.push_back(pathpattern);
}
}
}
}
// else: unknown tag, but that is fine, its XML
}
// now that we have all the objects created and references resolved, flatten
// the structure into something more useful for evaluating tests.
this->qtestobjects.clear();
this->qtestpatterns.clear();
for (auto& kv : qtestmap) {
QCriterion* bareptr = kv.second.qtest.get();
for (auto& p : kv.second.pathpatterns) {
this->qtestpatterns.push_back(std::make_pair(p, bareptr));
}
this->qtestobjects.push_back(std::move(kv.second.qtest));
}
// we could sort the patterns here to allow more performant matching
// (using a suffix-array to handle the "*" in the beginning)
}
DEFINE_FWK_MODULE(QualityTester);
|